Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow revoked GPG keys #91

Open
NicoHood opened this issue May 8, 2017 · 2 comments · Fixed by mxlgv/dino#57 · May be fixed by #1540
Open

Do not allow revoked GPG keys #91

NicoHood opened this issue May 8, 2017 · 2 comments · Fixed by mxlgv/dino#57 · May be fixed by #1540
Labels
good first issue Relatively easy to fix, makes a good start for first time contributors 🔒 OpenPGP Related to the OpenPGP encryption

Comments

@NicoHood
Copy link

NicoHood commented May 8, 2017

I have 3 private GPG keys on my system of which 2 are revoked. Those should not be able to select in the settings menu.
@fiaxh fiaxh added the 🔒 OpenPGP Related to the OpenPGP encryption label May 7, 2020
@fiaxh
Copy link
Member

fiaxh commented Mar 23, 2022

Currently we allow the user to select any available PGP key to use for PGP encryption. Instead, we should filter revoked or expired keys out and not display them.

@fiaxh fiaxh added the good first issue Relatively easy to fix, makes a good start for first time contributors label Mar 23, 2022
@fiaxh fiaxh mentioned this issue Mar 23, 2022
Closed
eerielili added a commit to eerielili/dino that referenced this issue Jan 20, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
616b9df 
	- closes dino#91
@eerielili eerielili linked a pull request Jan 20, 2024 that will close this issue
Open
@cjj20
Copy link

cjj20 commented Mar 27, 2024

@fiaxh I have made an attempt for this issue. See PR #1566

eerielili added a commit to eerielili/dino that referenced this issue Apr 12, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
779092c 
	- closes dino#91
	- Mention that GPG key may be expired or revoked:
	in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
eerielili added a commit to eerielili/dino that referenced this issue Apr 16, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
2f3ddad 
	- closes dino#91
	- Mention that GPG key may be expired or revoked:
	in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
	- blocks input in chat box if key is use is revoked or expired
vlomovtsev pushed a commit to vlomovtsev/dino that referenced this issue Apr 17, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
9310123 
	- closes dino#91
	- Mention that GPG key may be expired or revoked:
	in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
	- blocks input in chat box if key is use is revoked or expired

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <vlomovts@yandex.ru>
vlomovtsev added a commit to vlomovtsev/dino that referenced this issue Apr 17, 2024
@vlomovtsev
OPENPGP PLUGIN: Don't list expired/revoked GPG key
080ab6c 
	- closes dino#91
	- Mention that GPG key may be expired or revoked:
	in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
	- blocks input in chat box if key is use is revoked or expired

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
@vlomovtsev vlomovtsev mentioned this issue Apr 17, 2024
Merged
vlomovtsev added a commit to vlomovtsev/dino that referenced this issue Apr 17, 2024
@vlomovtsev
OPENPGP PLUGIN: Don't list expired/revoked GPG key
50767be 
This commit is to implement follwoing changes:
 - closes dino#91;
 - Mention that GPG key may be expired or revoked:
   in the account dialog if the number of OpenPGP keys found is 0,
   the label also notes that a key may have been revoked or expired;
 - blocks input in chat box if key is use is revoked or expired;

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
mxlgv pushed a commit to mxlgv/dino that referenced this issue Apr 17, 2024
@vlomovtsev
OpenGPG plugin : Fixed don't list expired/revoked GPG key (#57)
8f4d789 
This commit is to implement follwoing changes:
 - closes dino#91;
 - Mention that GPG key may be expired or revoked:
   in the account dialog if the number of OpenPGP keys found is 0,
   the label also notes that a key may have been revoked or expired;
 - blocks input in chat box if key is use is revoked or expired;

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
VadimNk pushed a commit to VadimNk/dino that referenced this issue Apr 18, 2024
@vlomovtsev @VadimNk
OpenGPG plugin : Fixed don't list expired/revoked GPG key (mxlgv#57)
5fdd7da 
This commit is to implement follwoing changes:
 - closes dino#91;
 - Mention that GPG key may be expired or revoked:
   in the account dialog if the number of OpenPGP keys found is 0,
   the label also notes that a key may have been revoked or expired;
 - blocks input in chat box if key is use is revoked or expired;

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
eerielili added a commit to eerielili/dino that referenced this issue Apr 21, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
bcbbacf 
	- closes dino#91
	- Mention that GPG key may be expired or revoked in chat input
	box
	- in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
	- blocks input in chat box if key is use is revoked or expired
	- if current selected key is revoked or expired, it'll be shown
	  in account manager with a warning message: "Attention
	  required: your key xxxx is revoked/expired!"
eerielili added a commit to eerielili/dino that referenced this issue Apr 26, 2024
@eerielili
OPENPGP PLUGIN: Don't list expired/revoked GPG key
78664dd 
	- closes dino#91
	- Mention that GPG key may be expired or revoked in chat input
	box
	- in the account dialog if the number of OpenPGP keys found is
	0, the label also notes that a key may have been revoked or
	expired.
	- blocks input in chat box if key is use is revoked or expired
	  when switching conversation and can detect if your key has expired
	  while chatting
	- if current selected key is revoked or expired, it'll be shown
	  in account manager with a warning message: "Attention
	  required: your key xxxx is revoked/expired!"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix, makes a good start for first time contributors 🔒 OpenPGP Related to the OpenPGP encryption
Projects
None yet
Milestone
No milestone
3 participants
@NicoHood @fiaxh @cjj20