Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to use fleet without using a nightly toolchain #4

Open
Milo123459 opened this issue Apr 23, 2022 · 4 comments
Open

Be able to use fleet without using a nightly toolchain #4

Milo123459 opened this issue Apr 23, 2022 · 4 comments
Labels
enhancement New feature or request
Projects

Comments

@Milo123459
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Nightly is unstable and I don't want to use it for my application.

Describe the solution you'd like
A clear and concise description of what you want to happen.

An option to disable whatever options require nightly rust to be used.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@suptejas
Copy link
Member

We'll work on this.

@lucasfernog
Copy link

An interesting approach for now would be to allow by default Cargo to be the stable one so I can easily use fleet only in the projects that I want or can. So you'd need to change your process::Command usage to include the +nightly argument.

@omac777
Copy link

omac777 commented Apr 23, 2022

We wish fleet would be a drop-in replacement for cargo accepting all cargo conformant cli args.
These currently are not valid with fleet, but I'm certain others would hope it would be:
RUSTFLAGS=-Awarnings fleet +stable build --release --verbose
RUSTFLAGS=-Awarnings fleet +nightly build --release --verbose
RUSTFLAGS=-Awarnings fleet +nightly-2022-04-19 build --release --verbose

Currently it's unclear which toolchain is used when building. I believe it should be stated as part of the output at the beginning.
I also believe it should state whether it is building a release or a debug binary as well.

Cheers and thank you for listening.

@suptejas suptejas added the enhancement New feature or request label Apr 24, 2022
@suptejas suptejas added this to To-Do in v1.0.0 Apr 25, 2022
@Milo123459 Milo123459 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2022
@suptejas suptejas reopened this Jul 15, 2022
@Milo123459
Copy link
Contributor Author

No real point reopening. Fleets optimisations in 9/10 cases don't help anymore due to new cargo optimisations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
v1.0.0
To-Do
Development

No branches or pull requests

4 participants