Possible bug when using datetime for default arguments

[NikosAlexandris]

The following default arguments might be a problem:

gee_sar_fetcher/geesarfetcher/__init__.py

Lines 30 to 31 in 7902015

	start_date: datetime = date.today()-timedelta(days=365),
	end_date: datetime = date.today(),

Default arguments are evaluated at import time. If importing is performed at 23:59 in an interactive session, then running the script at 00:01, a day will be missing from the results. Likewise in a long running script which might start at 23.40 and fetch() gets to run after 00:00.

Suggested solution

def foo(start_date = None):
    if start_date is None:
        start_date = datetime.today() - timedelta(days=365)

or make these mandatory arguments.

(Kindly suggested by https://github.com/pmav99)

[dimartinot]

This is a very good suggestion, I will work into it.

Thanks,