Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adding validation and eye button in password in Login and Signup Page #851

Open
3 tasks done
raghavawasthi24 opened this issue May 12, 2024 · 9 comments
Open
3 tasks done
Assignees
Labels

Comments

@raghavawasthi24
Copy link

Is your feature request related to a problem? Please describe.

  1. Frontend validation in login page which would restrict user from entering wrong
  2. Eye button in password field to view or unview password

Screenshot (234)

Describe the solution you'd like

I would use regex for validation and on eye button , I would switch password through JS.

Alternatives

No response

Additional Context

No response

Are you interested in contributing?

  • I'd like to work on this issue

Code of Conduct

  • I have used the search function to check if an issue already exists
  • I agree to follow this project's Code of Conduct

Which program are you contributing in?

gssoc

Copy link

linear bot commented May 12, 2024

Copy link

Hello @raghavawasthi24! 🌟
Thanks a bunch for creating an issue. Your input is invaluable, and we're eager to collaborate with you to address the matter. Keep up the fantastic work!

Don't forget to hit the ⭐ star button 😉

Tip

Don't forget to check our Contributing Guidelines, PR Guidelines and Issue Guidelines for more details.

Website | Discord | Twitter | Instagram | Linkedin

@pranshugupta54 pranshugupta54 changed the title [Feature]: Adding validation and eye button in password in Login Page [Feature]: Adding validation and eye button in password in Login and Signup Page May 12, 2024
@pranshugupta54
Copy link
Member

Hey @raghavawasthi24, we'll take this issue for adding to both Login and Signup screens.

@raghavawasthi24
Copy link
Author

@pranshugupta54 can you give level 3?

@pranshugupta54
Copy link
Member

What validations are you going to add?
(Eye for password is going to simple)

@raghavawasthi24
Copy link
Author

raghavawasthi24 commented May 12, 2024

like currently,

  1. you can signup with only spaces in name
  2. no restriction on length of password ( password length must be atleast 4)
  3. currently special symbols like %,#,$ are also accepted in name
  4. Replacing current validations with regex ( regex is popular for validating fields)

@pranshugupta54
Copy link
Member

@raghavawasthi24, ohk. We have them in backend + firebase directly. Would be better on frontend too right. Would be better if you add some steps below the password form like

  • 4 chars
  • no special char
  • atleast 1 number

Maybe send link to a website which has it for reference.

Also add a line on signup saying something similar to - accepting terms and also to receive mails on signup

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@INam1995
Copy link

INam1995 commented Jun 6, 2024

@pranshugupta54
i would like to implement these functionalities at time of signup or login , under GSSOC'24
Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants