-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: DarkMode / Light Mode want to add #824
Comments
Hello @tusharyadav11! 🌟 Don't forget to hit the ⭐ star button 😉 Tip Don't forget to check our Contributing Guidelines, PR Guidelines and Issue Guidelines for more details. |
Hey @tusharyadav11, how are you planning to implement this? We're using tailwind and daisyui - are you going to make config changes to them or some other way? Did you setup locally? (We'll assign this issue on the basis of best approach) |
i am trying to implement it you Js,css and html @pranshugupta54 |
Doing it directly with html css js won't be good here. |
Hey pranshugupta54 , Please assign this issue to me |
Hey @aasthakourav20, please read the above comments.
|
Hey @pranshugupta54 is the issue resolved? |
hi @pranshugupta54 , here's my approach on how will i implement the dark mode:
|
@yashmandi, please check tailwind docs and daisyui docs. There is no need to change the classes from bg-black to bg-white on switch, that will require us to change almost everything. |
Using tailwind CSS, we can add darkMode selector to tailwind config file
|
That sounds a better approach, we'd probably need to change some classes too. |
@pranshugupta54 hey pranshu assign it to me dark mode functionality . recently only i have implemented dark mode functionality using darkowl without changing up the any classes |
@tusharyadav11, describe the approach more. We don't want you to just get inverted colors |
it is a type of script . we just have to insert it into the code and automatically created the toggle button for the switch of light mode to dark and vice versa |
How will it work? You're not giving any approach at all. Just a button to flip makes no sense |
Doing dark mode is not about only changing background color; the other components colors needs to be adjusted as well to make them visible according to its background. So we have to change the some classes as well. |
Yeah, we gotta make classes like |
@pranshugupta54 as the whole site is already in dark mode, how you want site to look like in light mode? |
We don't really have any plans/roadmap for it, you'll have to work on the design too under the issue. |
OK no problem |
whats the timelimit for the assignment? |
This is a not a priority so you can take 7-10 days |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
I am working on it |
@pranshugupta54 home page have grid for dark mode, but for light mode the grid will not look good. |
@pranshugupta54 can you tell me from where this grid background is coming? |
Is your feature request related to a problem? Please describe.
Want to add the dark mode functionality
Describe the solution you'd like
I would like to work on this functionality. in my earlier projects i have worked on this functionality. I would be grateful if you could assign me this functionality under Gssoc'24
Alternatives
No response
Additional Context
No response
Are you interested in contributing?
Code of Conduct
The text was updated successfully, but these errors were encountered: