Problems with the Google Auth feature:

[filaliyasmine]

Contact Details

No response

What happened?

Code-wise:
=> Toast is not imported but is used, resulting in an unhandled exception.
User experience:
=> The google login fails but no error is displayed, and the google auth tab just closes without any feedback to the user.
There is a piece of code that displays an error but its only displaying the error code, its not an understandable message.

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Are you interested in contributing?

• I'd like to work on this issue

Code of Conduct

• I have used the search function to check if an issue already exists
• I agree to follow this project's Code of Conduct

[linear]

DIG-380 Problems with the Google Auth feature:

[github-actions]

Hello @filaliyasmine! 🌟
Thanks a bunch for creating an issue. Your input is invaluable, and we're eager to collaborate with you to address the matter. Keep up the fantastic work!

Don't forget to hit the ⭐ star button 😉

Tip

Don't forget to check our contributing guidelines for more details.

Website | Discord | Twitter | Instagram | Linkedin

[pranshugupta54]

@filaliyasmine, can you please describe a bit more? Or write steps to reproduce the issue? We do have an error message for auth.

[filaliyasmine]

#810

[filaliyasmine]

@filaliyasmine, can you please describe a bit more? Or write steps to reproduce the issue? We do have an error message for auth.

On my machine, the google Auth fails but it doesn't display anything. I checked the code and found out that it was using Toast to display an error, but it never imported it. also, the error is displayed in the wrong try-catch block. You can check my pull request for more clarity

[pranshugupta54]

@filaliyasmine, the only difference I can feel is defining a function and then using it in catch block. How will it make any changes? It's still doing the same thing 🤔 (Only the toast import needs to be done)

[pranshugupta54]

In the PR, the main logic for handling Google sign-in using Firebase authentication and making a POST request to the backend endpoint remains unchanged. The introduction of the new function for error handling doesn't alter the fundamental flow of the code. It's primarily a restructuring or enhancement for better error handling and notification, but the core logic remains the same.

[filaliyasmine]

yes the changes are made to better handle the error and display it

[pranshugupta54]

I don't really find any improvement. It's only toast being imported. Not useful to make a separate function when it's being used only once. Even the error message goes wrong "Gmail" - gmail and google auth are not completely same things.

[filaliyasmine]

The error is being catched in 3 seperate locations as seen below:

That's why I've added a function to handle it

[filaliyasmine]

is there anything else I need to do? @pranshugupta54

[pranshugupta54]

Just fix the formatting for that file.

[Gyanshu-Kumar]

can you assign this issue to me

[pranshugupta54]

Hey @Gyanshu-Kumar, this is already assigned.

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.