Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onion-grater profile for Whonix #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JeremyRand
Copy link
Contributor

@JeremyRand JeremyRand commented Mar 6, 2021

When running on Whonix-Workstation, Wahay sends an IP of 0.0.0.0 to ADD_ONION, which needs to be translated on the Whonix-Gateway to the Workstation IP. (This also reduces attack surface a bit.)

Fixes #26 . I haven't tested this with Tails but I'd be surprised if it breaks anything there.

Wahay sends an IP of 0.0.0.0 to ADD_ONION, which needs to be translated
on the Whonix-Gateway to the Workstation IP.  (This also reduces attack
surface a bit.)
@olabiniV2
Copy link
Contributor

Thank you for the contribution. I'm feeling a little bit uncomfortable with the hard-coded ports, since these are only the default potrs and can easily change. It would also be great to have a test on Tails to make sure it works there, before merging.

@JeremyRand
Copy link
Contributor Author

Thank you for the contribution. I'm feeling a little bit uncomfortable with the hard-coded ports, since these are only the default potrs and can easily change.

@olabiniV2 Are you saying the ports can change via run-time config changes, or via source code changes? onion-grater is in large part a sandboxing/hardening mechanism, so my preference is generally to make the profile as restrictive as possible without breaking functionality.

It would also be great to have a test on Tails to make sure it works there, before merging.

I don't have an easily accessible Tails machine but I'll see what I can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Connection refused" in Mumble when hosting on Whonix
2 participants