Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should check if ETH/ETC destination address is a contract or not #69

Open
knocte opened this issue Feb 19, 2019 · 12 comments
Open

Should check if ETH/ETC destination address is a contract or not #69

knocte opened this issue Feb 19, 2019 · 12 comments

Comments

@knocte
Copy link
Contributor

knocte commented Feb 19, 2019 •
edited

See https://gitlab.com/diginex/gwallet/issues/69
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.08 ETH (11.71 USD @ $146.41/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Feb 19, 2019 •
edited

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months, 1 week from now.
Please review their action plans below:

1) janus has been approved to start work.

This is me the chap that you assigned this task to...

As I wrote to you the other day , I would take 2 weeks to get up to speed with your choice language and programming environment. And I would be doing this task in 1-3 hours.

Once again thanks for this opportunity .

Learn more on the Gitcoin Issue Details page.

@knocte
Copy link
Contributor Author

knocte commented Feb 20, 2019

@e18r hey sorry, @janus contacted me first to work on this. If in 2 weeks there's no progress I'll pass it to you ;)

@gitcoinbot
Copy link

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@janus
Copy link
Contributor

janus commented Feb 23, 2019 via email

@janus
Copy link
Contributor

janus commented Feb 23, 2019

https://gist.github.com/janus/29a24b21d972446ce1861d44a0e28b96
The above is for @knocte to pass his comment before .. I update and add to the code base

@janus
Copy link
Contributor

janus commented Feb 28, 2019

https://gitlab.com/DiginexGlobal/geewallet/merge_requests/28

Please , @knocte , review my code

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 0.17 ETH (23.2 USD @ $136.47/ETH) .

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.17 ETH (21.24 USD @ $124.94/ETH) has been submitted by:

  1. @janus

@knocte please take a look at the submitted work:

@knocte
Copy link
Contributor Author

knocte commented Mar 4, 2019

PR link is wrong, this is the correct link: https://gitlab.com/DiginexGlobal/geewallet/merge_requests/29

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.17 ETH (21.24 USD @ $124.94/ETH) attached to this issue has been approved & issued to @janus.

@janus
Copy link
Contributor

janus commented Mar 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janus @knocte @gitcoinbot