Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At startup, clean up left projects that failed to delete #583

Closed
EvanHahn opened this issue Apr 25, 2024 · 0 comments · Fixed by #672
Closed

At startup, clean up left projects that failed to delete #583

EvanHahn opened this issue Apr 25, 2024 · 0 comments · Fixed by #672
Assignees
@EvanHahn
Labels
mvp Requirement for MVP

Comments

@EvanHahn
Copy link
Contributor

If we start to leave a project and the app crashes, we may fail to remove data from indexers. At startup, we should find left projects and remove the "orphaned" data.
@EvanHahn EvanHahn added the mvp Requirement for MVP label Apr 25, 2024
@EvanHahn EvanHahn mentioned this issue Apr 25, 2024
Merged
@EvanHahn EvanHahn self-assigned this Apr 25, 2024
EvanHahn added a commit that referenced this issue May 23, 2024
@EvanHahn
fix: at startup, clean up left projects that failed to delete
8089122 
If you start to leave a project and the operation fails partway, we now
finish the next time you try to load that project.

For example, imagine the following scenario:

1. The user presses the "leave project" button.
2. We mark them as having left the project, but haven't yet deleted any
   data.
3. Their phone runs out of battery.

Previously, the project state would be messed up in this scenario. Now,
we finish the cleanup before returning the project.

Fixes [#583].

[#583]: #583
@EvanHahn EvanHahn mentioned this issue May 23, 2024
Merged
EvanHahn added a commit that referenced this issue May 30, 2024
@EvanHahn
fix: at startup, clean up left projects that failed to delete (#672)
2589842 
If you start to leave a project and the operation fails partway, we now
finish the next time you try to load that project.

For example, imagine the following scenario:

1. The user presses the "leave project" button.
2. We mark them as having left the project, but haven't yet deleted any
   data.
3. Their phone runs out of battery.

Previously, the project state would be messed up in this scenario. Now,
we finish the cleanup before returning the project.

Fixes [#583].

[#583]: #583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
mvp Requirement for MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: at startup, clean up left projects that failed to delete digidem/mapeo-core-next
1 participant
@EvanHahn