Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using ISO strings for timestamps in API #567

Open
EvanHahn opened this issue Apr 16, 2024 · 0 comments
Open

Stop using ISO strings for timestamps in API #567

EvanHahn opened this issue Apr 16, 2024 · 0 comments
Labels
post-mvp de-scoped to after MVP

Comments

@EvanHahn
Copy link
Contributor

EvanHahn commented Apr 16, 2024

We use ISO strings for timestamps. This has a few issues, all minor:

  • It’s more data to (de)serialize over the IPC bridge
  • It’s harder to validate
  • It’s slower to parse as a Date (I assume)

To fix this, we should use something else (probably numbers) in the API.

To be clear, this does not affect any data on disk. That's stored as a protobuf google.protobuf.Timestamp, and that doesn't change as part of this task.

This probably requires work in @mapeo/schema more than anywhere else.

@EvanHahn EvanHahn added the post-mvp de-scoped to after MVP label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mvp de-scoped to after MVP
Projects
None yet
Development

No branches or pull requests

1 participant