Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback / Delete / Share #361

Open
6 of 9 tasks
ximenabb opened this issue May 15, 2024 · 2 comments
Open
6 of 9 tasks

Playback / Delete / Share #361

ximenabb opened this issue May 15, 2024 · 2 comments

Comments

@ximenabb
Copy link
Contributor

ximenabb commented May 15, 2024

Playback / Delete / Share

User has successfully saved an audio recording on a observation. User clicks on the recording from the observation. User can play it back, delete it or share it.

Todo

Screen Shot 2024-05-15 at 4 25 21 PM

Playback

  • Task is already here New audio recording #360
  • Only difference is, tapping the “X” button takes user to the Observation

Delete Audio Recording

  • Display bottom sheet as designed
  • Display red icon and Delete?
  • Display text Your Audio Recording will be permanently deleted. This cannot be undone.
  • Display Delete button, when clicked redirects to the Observation
  • Display Cancel button, when clicked close the modal

Share

  • No creating a custom share sheet (we need to update figma)
  • When tap share, use android share sheet

Tech Notes

Design

https://www.figma.com/design/1Knqv1NrijUuqMo1pvYyF7/Tracks-and-Audio-(Share)?node-id=529-657&t=xhcTH3fFF4S8gJjD-0

@ximenabb
Copy link
Contributor Author

Update :
Shared by @CDFN -
Hi, there is problem we encountered when developing share menu. Default Android SMS app (com.google.android.apps.messaging) isn't able to handle android.intent.action.SEND_MULTIPLE intent with audio/mp4 mime type, meaning we can't share audio via SMS as in design. WhatsApp works fine though. Apparently default SMS app is only capable of doing image/* and text/* mime types 😞
You'll need to make decision whether you want to use something else (different app) in place of messages or find some different solution. Let me know how we should proceed with this.

Decision made - share Whatsapp and More fore the MVP

@CDFN
Copy link
Collaborator

CDFN commented May 28, 2024

This issue can't be finished in full before #378 gets added, as currently there is no way to store attachment metadata (need to store creation timestamp + recording duration)

@ErikSin ErikSin unassigned CDFN Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants