Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeguards for when async storage retrieval fails #341

Open
achou11 opened this issue May 13, 2024 · 0 comments
Open

Add safeguards for when async storage retrieval fails #341

achou11 opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working dev experience

Comments

@achou11
Copy link
Member

achou11 commented May 13, 2024

Have only run into this during development but I think it highlights an eventual issue that we'd ideally avoid when it's deployed

Not sure about precise reproduction steps, but basically when opening the app, it sometimes gets stuck on the splash screen. I have to uninstall the app entirely or clear the app storage and restart the app in order to fix it. The annoying this is that there's no clear error that gets surfaced when this happens.

My suspicion is that there's something with the zustand persistence + mmkv where we run into this situation, mostly in development because of the frequent refreshes (via react fast refresh) or git branch switching. Think this mostly highlights the need to have the proper error handling in place in case this does happen in the wild (which it very much can)

Might require some design work in terms of figuring out what kind of error we should show (or if we should do something more aggressive?)

@achou11 achou11 added bug Something isn't working dev experience labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev experience
Projects
None yet
Development

No branches or pull requests

1 participant