Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Observation #311

Closed
8 tasks done
ErikSin opened this issue May 1, 2024 · 0 comments · Fixed by #365
Closed
8 tasks done

Edit Observation #311

ErikSin opened this issue May 1, 2024 · 0 comments · Fixed by #365
Assignees
Labels
MVP Needs to be completed for the initial QA release swmansion

Comments

@ErikSin
Copy link
Contributor

ErikSin commented May 1, 2024

When a user opens an observation, if it belongs to them, they should be able edit that observation. When the observation does belong to them, the top right icon should be the edit icon. Clicking on the edit icon should navigate user to the ObservationEdit Screen.

To Do

  • In ObservationHeaderRight determine if observation belongs to user using useDeviceInfo hook.
  • In ObservationHeaderRight,w hile deviceInfoHook is loading, show a UIActivityIndicator in place of any icon.
  • If the observation belongs to user, show the editIcon. The user should be able to press this icon and be navigated to the ObservationEdit Screen
  • If the observation does not belong to the user, show the syncIcon. User should not be able to click this screen
  • The ObservationEdit Screen using persisted state to hold all the data. Therefore when a user is editting an observation we put all the data into peristed state using editSavedObservation **Once the user is navigated to the ObservationEdit Screen and the observation has been passed to the editSavedObservation, the logic for updating the observation should already be implemented. **
  • Test that a user is able to update the observation and that the edits are saved
  • Test that a user can close the app while editting an observation, and when re-opening the app, they are navigated back to the edit observation screen
  • Test that a user will see a warning asking them if they want to not save their changes if they try to press the back button to navigate away from the screen
@ximenabb ximenabb added MVP Needs to be completed for the initial QA release swmansion labels May 8, 2024
@ErikSin ErikSin self-assigned this May 12, 2024
@ErikSin ErikSin removed the swmansion label May 12, 2024
@ErikSin ErikSin removed their assignment May 12, 2024
@bohdanprog bohdanprog self-assigned this May 14, 2024
@bohdanprog bohdanprog linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MVP Needs to be completed for the initial QA release swmansion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants