Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS support for Kotest runner #186

Open
5 tasks
nedtwigg opened this issue Feb 1, 2024 · 0 comments
Open
5 tasks

JS support for Kotest runner #186

nedtwigg opened this issue Feb 1, 2024 · 0 comments
Labels
enhancement New feature or request js

Comments

@nedtwigg
Copy link
Member

nedtwigg commented Feb 1, 2024 •
edited

JS seems like the easiest next step, but PRs for native platforms are welcome too!

  • in selfie-lib, move tests from jvmTest to commonTest one by one and implement the missing part
    • most tests are already in commonTest, here is a suggested order for the 5 which are stuck in jvmTest
    • LineReaderTest, SnapshotValueReaderTest, SnapshotReaderTest, SnapshotFileTest (sequentially in one PR)
    • RecordCallTest in its own PR, perhaps needs to stay platform-specific
  • in selfie-runner-kotest search for TODO: https://github.com/diffplug/selfie/issues/186
  • move HarnessVerifyTest out of jvmTest and into commonTest
@nedtwigg nedtwigg added enhancement New feature or request js labels Feb 1, 2024
This was referenced Feb 1, 2024
Open
Closed
@nedtwigg nedtwigg changed the title Make our Kotest runner support js Make our Kotest runner support js and others Feb 11, 2024
@nedtwigg nedtwigg changed the title Make our Kotest runner support js and others JS support for Kotest runner Feb 11, 2024
@nedtwigg nedtwigg mentioned this issue Feb 12, 2024
Merged
Kantis pushed a commit to kotest/kotest that referenced this issue Feb 14, 2024
@nedtwigg
Add selfie snapshot testing to the extensions listing (#3870)
deb8d2a 
Selfie just released its `1.2.0` version which added support for Kotest.

- add
`testImplementation("com.diffplug.selfie:selfie-runner-junit5:1.2.0")`
- add `override fun extensions() = listOf(SelfieExtension(this))` to
your `AbstractProjectConfig`
- do snapshot testing! https://github.com/diffplug/selfie

It's written in KMP, but there are some stubs which have only been
implemented for JVM so far. If anyone is interested in helping with
other platforms:

- diffplug/selfie#186

Also perhaps of interest to Kotest folks:

- diffplug/selfie#214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nedtwigg