Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug, Move Package] Support case-insensitive file systems #10056

Open
tzakian opened this issue Dec 17, 2021 · 1 comment
Open

[Bug, Move Package] Support case-insensitive file systems #10056

tzakian opened this issue Dec 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tzakian
Copy link
Contributor

tzakian commented Dec 17, 2021

If you have a Move package with two modules (or any combination of Module/Script) that have the same name modulo-case (e.g., "set" and "Set"), then the resulting compiled package will be invalid.

This is due to the fact that we choose the filename based on the module/script name. On case-insensitive file systems this will lead to use overwriting one file (the one for e.g., "Set") with the other (e.g., "set").

We need to figure out a good way of supporting case-insensitive file systems and/or raising an error or warning to the user when they have module/script names that may trigger this issue.

@tzakian tzakian added the bug Something isn't working label Dec 17, 2021
@tzakian tzakian self-assigned this Dec 17, 2021
@tzakian
Copy link
Contributor Author

tzakian commented Jan 5, 2022

After some offline discussion the current plan to resolve this issue is to make it an error if you have modules/scripts that would cause issues on a case-insensitive filesystem (regardless of the file system you're currently on). While a bit restrictive we feel this is fine since:

  • The solution is relatively straightforward and we can provide a good error message/help on what to do
  • It maximizes reusability of Move packages by other people (e.g., someone develops a package that works on their Linux machine, but then I can't use their package on my Mac machine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant