Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Uses of valueToString and such use default malloc and free #476

Open
1 task done
Jason2605 opened this issue Oct 20, 2021 · 0 comments
Open
1 task done

Comments

@Jason2605
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem?

Uses of valueToString and such use default malloc and free, it would be much better if it was handled via the macros provided within https://github.com/dictu-lang/Dictu/blob/develop/src/vm/memory.h

This means if we ever need to swap allocator at some point in the future, it's all handled in a single place. It also means that the GC isn't running when it potentially should be as this is happening outside the realm of the memory watermark.

Describe the solution you'd like

No uses of malloc / realloc / free within the project, all handled through the macros.

Describe alternatives you've considered

No response

Additional context

No response

@Jason2605 Jason2605 self-assigned this Oct 24, 2021
@Jason2605 Jason2605 removed their assignment Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant