test_heads_up_after_flop bug

[dsfdsfgdsa]

Here the first actions from test_heads_up_after_flop and an assert which follow after that.
env.step(Action.ALL_IN) # seat 3 utg
env.step(Action.ALL_IN) # seat 4
env.step(Action.ALL_IN) # seat 5
env.step(Action.ALL_IN) # seat 0
env.step(Action.CALL) # seat 1 small blind = all in
env.step(Action.FOLD) # seat 2 big blind folds
assert sum(env.player_cycle.alive) == 2

This test has in my oppinion several bugs.

1. After all actions should no player alive, because 5 players are allin they have a remaining stack of 0 so they cant do any additional actions. 1 player fold, so no actions is possible. But this test is a green one. I try to fix this, but i see that env.player_cycle.alive changed behaviour often. Sometimes is index 2 and 4 true other times index 0 and 3 and so on.
2. See 1 the test name and the implemented behavior is not the same. Test name expected a heads up, but there is no generation of a scenario for headsup.

Because of these points I recommend to ignore this test and and also add a comment why is it ignored.

[dickreuter]

Yes sounds good, please feel free to make the necessary changes. Ideally don't just comment out the test but fix it. We still need more test coverage and there are still edge cases that don't appear to be handled correctly. thanks

[dsfdsfgdsa]

Yeah I agree a better test coverage would be nice. But in that case is a higher time afford required, because of changed behavior for env.player_cycle.alive by several executions of the test. I can only offer comment the test with my findings or ignore and comment. But dont worry I will try to find more bugs and cover my new findings with tests.

[dickreuter]

Sounds good

…

On Mon, 15 Jun 2020 at 13:16, dsfdsfgdsa ***@***.***> wrote: Yeah I agree a better test coverage would be nice. But in that case is a higher time afford required, because of changed behavior for env.player_cycle.alive by several executions of the test. I can only offer comment the test with my findings or ignore and comment. But dont worry I will try to find more bugs and cover my new findings with tests. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJSW7V4XMSCWYIBBJJKZ4LRWYGIDANCNFSM4N6DGKOQ> .