Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue Report]: Full screen option on Nintendo Switch #7032

Open
locksoft opened this issue Mar 17, 2024 · 5 comments
Open

[Issue Report]: Full screen option on Nintendo Switch #7032

locksoft opened this issue Mar 17, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@locksoft
Copy link

locksoft commented Mar 17, 2024

Operating System

Nintendo Switch

DevilutionX version

1.5.2

Describe

I guess the full screen option is meant for desktop versions of the app. On consoles like Nintendo Switch it has no sense, as there's not a desktop. So, enabling it, creates some weird results, depending on the set screen dimension (480p, 720p, 1080p):

SI_1

SI_2

Maybe is it better to remove it in the next releases?

I also noticed other options that seem not useful at all on a console, like the keyboard shortcuts settings (the gamepad one is the only working here).

To Reproduce

Settings > Graphics > Full screen

Expected Behavior

No option at all.

Additional context

No response

@AJenbo AJenbo added the good first issue Good for newcomers label Mar 17, 2024
@DakkJaniels
Copy link
Contributor

Isn't that how it works on PC? If you turn off full screen, it doesn't upscale the pixels to your screen resolution.

@AJenbo
Copy link
Member

AJenbo commented Mar 17, 2024

Not quite, but sort of.

Anyway it would probably be fine to have a condition to set this to hidden for consoles (same as with quit)

@locksoft
Copy link
Author

Anyway it would probably be fine to have a condition to set this to hidden for consoles (same as with quit)

I think it’s possible to quit apps on the Switch, several emulators and utilities have an option for that (not sure if official games do, however). But it’s something like the broken sounds after the console wakes up from the sleep: I’ve no idea about where to report the problems (I can’t sign up in the dev-kit forum, and I’ve no idea who’s working on the Switch porting of this code).

@AJenbo
Copy link
Member

AJenbo commented Mar 18, 2024

But it’s something like the broken sounds after the console wakes up from the sleep

Probably we do not want that.

I’ve no idea about where to report the problem

Is it a problem?

I’ve no idea who’s working on the Switch porting of this code

No one is actively maintaining switch support, which makes it hard to do anything specific for Switch

@locksoft
Copy link
Author

But it’s something like the broken sounds after the console wakes up
I’ve no idea about where to report the problem
Is it a problem?

The quit one not at all. :)
The sound yes, it means you can’t turn the Switch off (without restarting the game).

I’ve no idea who’s working on the Switch porting of this code
No one is actively maintaining switch support, which makes it hard to do anything specific for Switch

I see. Many thanks for keep working on it then. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants