Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Alternate Belt Auto-Fill #6826

Open
tunbridgep opened this issue Nov 20, 2023 · 11 comments
Open

[Feature Request]: Alternate Belt Auto-Fill #6826

tunbridgep opened this issue Nov 20, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@tunbridgep
Copy link

Feature Type

Quality of Life

Describe

Belt autofill is quite nice, however I tend to find quite often that my belt fills up with crap.

Ideally I would like to have 4 or so slots for health potions, a few for mana potions, maybe a rune, and a scroll of some sort, or maybe half and half Health and Mana potions.

Currently, autofill just fills up the belt whenever it can, including with scrolls, etc. I like to meticulously manage my belt, and have to choose between either completely filling the belt manually and turning off autofill, or putting up with empty slots being filled with crap. This is usually an issue when I run out of potions, the slots become empty and can be filled by whatever, usually stuff I don't want on my belt.

I feel like a setting should be added, called "alternate belt auto fill", which, when enabled, will give more fine-grained control over what goes into your belt

The way it would work is like this:

  1. Place an item in a belt slot, such as a healing potion.
  2. When the item in that type is used up, and is not automatically refilled, the slot becomes "grayed out", showing a transparent version of the item.
  3. Only other items of the same type can be automatically added to that belt slot, either through inventory autofill, or by picking one up off the floor.
  4. Right-clicking on the grayed out slot will remove the filter and make it act as it normally does already.

This should be relatively easy to understand for players, intuitive, and very flexible for different people's needs surrounding the belt.

@tunbridgep tunbridgep added the enhancement New feature or request label Nov 20, 2023
@Trihedraf
Copy link
Collaborator

Turning on auto fill belt doesn't add stuff to your belt that you pick up. It auto replaces the potion you use in your belt with one in your inventory. Your belt filling with the stuff as you run out is vanilla Diablo behavior.

@AJenbo
Copy link
Member

AJenbo commented Nov 20, 2023

How do you gray out a gray square 🤔

@AJenbo
Copy link
Member

AJenbo commented Nov 20, 2023

I think the way to facilitate this would be to add a way for Lua to evaluate if an item should be placed in the belt.

To make it possible to make the described interactions work (which could make the mod more user friendly) we could have to also expose a way to draw the item sprites and receive mouse events. Both of these mess well with the goal of being able to implement interfaces via Lua.

@FitzRoyX
Copy link

To me this just seems like an inferior version of potion stacking. You would need ugly colored gui overlays to mark what type of item you want in each slot, and then there would be lots of misclick potential where you accidentally "reassign" an empty slot when trying to pick up a belt item.

The existing auto refill feature does a pretty darn good job of simulating potion stacking as it is. How is junk getting into your empty belt slots unless you've depleted your potions? If you've depleted your potions, isn't that town portal restock time anyway?

@AJenbo
Copy link
Member

AJenbo commented Nov 24, 2023

Why a colored overlay, a ghost version of the pod should work (like the left side of a 2 handed weapon)

@FitzRoyX
Copy link

Couldn't that be confusing in a game this dark, a bunch of ghost potions might look at a glance like they're real? But also, needing to have an item to set a slot, and then right-clicking to unset it when right-click is also bound to using potions? That system would also result in annoying misclicks.

@AJenbo
Copy link
Member

AJenbo commented Nov 24, 2023

The don't enable the mod, besides the panels aren't dark

@julealgon
Copy link
Contributor

Another (perhaps more elaborate) idea would be to expose some sort of belt configuration menu/UI where the player could configure what each slot in the belt could carry.

For example:

  • slot1: full healing potions | full rejuvenation potions
  • slot2: any healing potions | any rejuvenation potions
  • slot3: any mana potions | any rejuvenation potions
  • slot4: disabled (allow players to "turn off" belt slots)
  • slot5: anything (not configured)
  • slot6: all scrolls except fire wall/town portal (add exclusion rules)
  • slot7: fire wall scrolls
  • slot8: town portal scrolls

Once configured, all game pickup and "move-to-belt" routines would respect these settings, and player attempts at placing different items in them manually by dragging would also be conditionally blocked.

Configuration could also potentially define a "priority". Take slot1 as an example there: when the potion is consumed, and "fill from inventory" is enabled, it could prioritize filling the slot with a Full Healing potion instead of a Full Rejuvenation potion if both are available for refill.

Could even make it so that this configuration was performed by Griswold or something, with an additional vendor UI page.

Obviously, this setup would be per-character and have to live as part of the save file using one of those extension file add-in things that you guys have.

@qndel
Copy link
Member

qndel commented Nov 24, 2023

newbeltfeature
I added a "ghost" row in tchernobog that lets you select item type that goes there

@tunbridgep
Copy link
Author

@qndel
That looks awesome. I should really check out tchernobog at some point. However, having something like this work with vanilla could be good too.

@qndel
Copy link
Member

qndel commented Mar 10, 2024

@qndel That looks awesome. I should really check out tchernobog at some point. However, having something like this work with vanilla could be good too.

d1's belt is so limited I don't really see a point 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants