Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactions to comments for likes #61

Closed
tclaus opened this issue Feb 12, 2021 · 2 comments
Closed

Add interactions to comments for likes #61

tclaus opened this issue Feb 12, 2021 · 2 comments

Comments

@tclaus
Copy link
Member

tclaus commented Feb 12, 2021

To implement diaspora/diaspora#8203 a comment can have one or more likes.
A comment should have a interactions node, with a likes array and likes_count. Similar to post.interactions.
"interactions": { "likes": [..], "likes_count": 42 }

Is this OK to extend a comment json this way?

Bildschirmfoto 2021-02-12 um 19 55 19

@Flaburgan
Copy link
Member

Yep looks good to me, and as @jhass also thumbed up I would say it's fine. Would you mind opening a pull request?

@tclaus
Copy link
Member Author

tclaus commented Feb 15, 2021

Wat comes into my mind - for the API part, the like has an author, the author has an avatar, the avatar is an image, or a list of three different avatars.
I think for the API the avatar may only be one image (the small one), and for the backbone(?) all thee kinds of profile images?

SuperTux88 added a commit that referenced this issue Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants