Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard option to exclude_images #2561

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

graeme-winter
Copy link
Contributor

Allows exclude_images=*:a:b to exclude a-b from every run

Fixes #2560

I suspect there is a more elegant way to do this, but this does meet the brief.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #2561 (86a3707) into main (8f16d0a) will decrease coverage by 0.02%.
The diff coverage is 27.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   78.77%   78.75%   -0.02%     
==========================================
  Files         609      609              
  Lines       74791    74801      +10     
  Branches    10668    10673       +5     
==========================================
  Hits        58913    58913              
- Misses      13683    13692       +9     
- Partials     2195     2196       +1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.scale: allow wildcard for experiment in exclude_images
2 participants