Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a style’s custom layer sets it to the default #2188

Open
Purgatory63 opened this issue Apr 18, 2024 · 1 comment
Open

Renaming a style’s custom layer sets it to the default #2188

Purgatory63 opened this issue Apr 18, 2024 · 1 comment
Labels
Bug 🐞 Something isn't working Critical 💩

Comments

@Purgatory63
Copy link

The problem

Renaming a newly created style’s custom layer causes the custom layer to replace the premade layer.

Describe the bug

If you make a custom layer (my examples are custom text box layers) and rename it immediately (presumably any time after creating, as long as you don’t make a new style before renaming the file), it will cause the scene in the renamed file to somehow become the default, replacing the premade style.

Deleting the now default style causes you to be unable to make any new styles, and reloading the project will result in all styles (even if they seemed fine before) to vanish. Dragging their file back into the style bar results in no layers, only the default layer base.

I’ve got some videos of it, apologies that it’s pretty slow.

To Reproduce
Steps to reproduce the behavior:

  1. Create a style based off the premade one
  2. Make a layer (ex: text box) custom
  3. Edit the newly created folder name for the custom layer
  4. Create a new style also based off the premade one
  5. Whatever layer you replaced will also be in the new style

Expected behavior
Naming the folder should only change its name, and the default layer should remain as the premade one.

Videos
https://youtu.be/lBML-5BfzcM?si=xmPhot3ySk2zRzxh (This one has timestamps to skip past me being slow)

https://youtu.be/cIr5fVWRx2g?si=5-E0m7eTpNBGMr39

https://youtu.be/Nh4aAhknv2Q?si=bkcrbCUaUVa_PmzW (Continuing (mostly) directly from the second video)

System (please complete the following information):

  • OS: Windows 10
  • Godot Version: 4.2.1.stable.mono.official
  • Dialogic Version: 2.0-Alpha-13

Solutions

Workaround
What you tried to get the feature working:
I did not test with this part much, but it seems like creating a new style, then going back to edit the previous layers name doesn’t cause this glitch to happen (seen in 2nd video)

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Critical 💩 labels Apr 18, 2024
@Jowan-Spooner
Copy link
Collaborator

Thanks, I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Critical 💩
Projects
None yet
Development

No branches or pull requests

2 participants