Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await Background Finishing #2143

Open
CakeVR opened this issue Mar 18, 2024 · 1 comment
Open

Await Background Finishing #2143

CakeVR opened this issue Mar 18, 2024 · 1 comment
Labels
Enhance ⚡ Improve a feature's workflow.

Comments

@CakeVR
Copy link
Collaborator

CakeVR commented Mar 18, 2024

Adding the option for the timeline to await a background to finish will add more power for cinematic background scenes.

For instance, awaiting an animation to finish playing before the timeline will advance. Similar to awaiting character transitions.

I would recommend to add a finish method, like we have for events.

@CakeVR CakeVR added the Enhance ⚡ Improve a feature's workflow. label Mar 18, 2024
@Pheubel
Copy link
Contributor

Pheubel commented Apr 25, 2024

It actually does have a call to finish already (see addons/dialogic/Modules/Background/event_background.gd line 60).

Instead, what I think would have to happen is that the call to update_background() needs to cause the execution of the event to stall until it is finished. Diving into that function, between lines 126 and 135 seem like a good place to have logic related to waiting for the background to finish.

One way to do this is to have a timer run and wait for it to expire.

In my opinion backgrounds should by block the execution of the timeline, but with an optional setting where the transition can become skip-able upon receiving user input. Additionally with another mode to have the same behavior as now, where it just gets told what background to show and nothing more, for scenarios where background changes should happen during dialog, like exposition scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Development

No branches or pull requests

2 participants