Background subsystem throws an error when it tries to call transition_finished after background node isnt in tree anymore.

[catpieyum]

The problem

When using the background event with a fade time of lets say 3 seconds, while transitioning, we move onto the next background event or end the timeline, an error pops up saying "Error calling from signal 'transition_finished' to callable: 'Node(subsystem_backgrounds.gd)::_on_transition_finished': Cannot convert argument 1 from Object to Object."

To Reproduce
Steps to reproduce the behavior:

1. Add background event to timeline with fade time of 0
2. Add a text event
3. Add background event to timeline with fade time of 3 without any image

System (please complete the following information):

• OS: Windows
• Godot Version: 4.2.1.stable
• Dialogic Version: 2.0.a13

Possible fixes
Disconnecting transition_finished before freeing the node should probably fix it. Or checking if node still exists when calling transition_finished.

[Jowan-Spooner]

Hey @catpieyum it's been a while, but I'm trying to recreate this, and I'm not getting the error. This is the timeline I'm testing:

[background arg="res://test-project/Backgrounds/Bedroom 27.png" fade="0.0"]
[wait time="1.0"]
[background fade="3.0"]
[wait time="1.0"]
[background arg="res://test-project/Backgrounds/Bedroom 27.png" fade="0.0"]
[wait time="1.0"]
[background fade="3.0"]
[wait time="1.0"]

Am I missing something? Can you share a video of this happening (can be on discord). Or the timeline snippet that does this? Thanks!

[catpieyum]

I will take a video soon and send it here or in Discord 👍