Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] ability to delete bookmarks #37

Open
rkulla opened this issue Sep 30, 2023 · 1 comment
Open

[feature request] ability to delete bookmarks #37

rkulla opened this issue Sep 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rkulla
Copy link

rkulla commented Sep 30, 2023

A keyboard shortcut to delete the selected bookmark(s) would be useful, especially for people who like to have a "Read Later" folder for reviewing tutorials, pull-requests, etc.

If this is possible, ideally it would have an optional confirmation prompt and maybe a second shortcut or option to automatically delete and open at the same time (to not have to go back into it to delete later).

Thanks for this very useful plugin!

@dhruvmanila
Copy link
Owner

Thanks for using the plugin! Good to know you find it useful :)

Deleting any bookmarks would involves updating the local bookmarks file which I'm not too sure about. The reason being that if the plugin did remove the entry, there's a chance that the file would become unreadable by the browser as it might expect it in a certain format.

We could determine the diff before and after a bookmark is removed by the browser to determine what kind of change should be done by the plugin to perform the same action but might involve some effort in doing so.

That said I'm not against supporting it, if anyone wants to contribute this feature I would be happy to help them. I might take a look at it when I get bored ;)

@dhruvmanila dhruvmanila added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants