Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getValue helper function in PhotoViewer #255

Open
ryaanahmed opened this issue Nov 3, 2022 · 0 comments
Open

remove getValue helper function in PhotoViewer #255

ryaanahmed opened this issue Nov 3, 2022 · 0 comments

Comments

@ryaanahmed
Copy link
Member

There's a function getValue in frontend/components/PhotoViewer.js that takes a dict, looks for a key, and returns a supplied default value if the key is missing.

Looks like the author was trying to get default values for a config dict going -- we can replace a dict of default args, or use the || operator to provide the same basic functionality.

e.g., instead of
const className = getValue(config, "className", "");

do this:
const className = config.className || "";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant