Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previous_next_photos should not increment/decrement by ID #254

Open
ryaanahmed opened this issue Nov 3, 2022 · 0 comments
Open

previous_next_photos should not increment/decrement by ID #254

ryaanahmed opened this issue Nov 3, 2022 · 0 comments
Assignees

Comments

@ryaanahmed
Copy link
Member

app.views.previous_next_photos looks for the previous/next photos in a given map square.

Currently it does this by looking at the photos with the next lower/higher database id number. This relies on all photos in a given map square having sequential ids, which is something we do not guarantee. Currently it works because all of our methods for rebuilding the database do actually enter photos in order, but we shouldn't rely on this.

Instead, it should increment/decrement via Photo.number and Photo.folder.

@Menamonmon Menamonmon self-assigned this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants