Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue318 add test presentation digest already anchored #360

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shashankiitbhu
Copy link

Fixes #318

Add test to validate PresentationDigestAlreadyAnchored error in add_presentation call

Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashankiitbhu Please fix confilcts by rebasing with upstream & fix below errors,

error: unused variable: `new_statement_digest`
    --> pallets/statement/src/tests.rs:1037:6
     |
1037 |     let new_statement_digest = <Test as frame_system::Config>::Hashing::hash(&new_statement[..]);
     |         ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_statement_digest`
     |
     = note: `-D unused-variables` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: unused variable: `schema_id`
    --> pallets/statement/src/tests.rs:1052:6
     |
1052 |     let schema_id: SchemaIdOf = generate_schema_id::<Test>(&schema_id_digest);
     |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_schema_id`
     ```

@vatsa287
Copy link
Member

vatsa287 commented May 6, 2024

@shashankiitbhu Please fix confilcts by rebasing with upstream & fix below errors,

error: unused variable: `new_statement_digest`
    --> pallets/statement/src/tests.rs:1037:6
     |
1037 |     let new_statement_digest = <Test as frame_system::Config>::Hashing::hash(&new_statement[..]);
     |         ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_statement_digest`
     |
     = note: `-D unused-variables` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: unused variable: `schema_id`
    --> pallets/statement/src/tests.rs:1052:6
     |
1052 |     let schema_id: SchemaIdOf = generate_schema_id::<Test>(&schema_id_digest);
     |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_schema_id`
     ```

@shashankiitbhu ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C4GT] Statement: Add tests for PresentationDigestAlreadyAnchored
2 participants