Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you only do slice on top level? #38

Open
Isuxiz opened this issue May 19, 2022 · 1 comment
Open

Why you only do slice on top level? #38

Isuxiz opened this issue May 19, 2022 · 1 comment

Comments

@Isuxiz
Copy link

Isuxiz commented May 19, 2022

Hi, I noticed that in the r-tree implementation where in file "rtree.go", you only do the slicing at the root level, the other levels use just one slice whose length is the size of entire current subdataset (i.e. don't slice).

May i ask why you are doing this?

From what I have observed, if the slicing strategy is used in every height of recursion, it is possible to generate better leaf MBRs (their length and width are closer rather than one being much larger than the other).

@dhconnelly
Copy link
Owner

Good question! Unfortunately I do not remember. My intention was to follow the algorithm as outlined in the linked papers, so if slicing at every height is implemented there, then probably this was just an oversight. I'd be happy to evaluate a pull request that changes this though, particularly if there's some benchmarking that shows it outperforms the existing implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants