Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Find new TS linter #74

Open
joshua-goldstein opened this issue Jun 3, 2023 · 0 comments
Open

[Deps] Find new TS linter #74

joshua-goldstein opened this issue Jun 3, 2023 · 0 comments

Comments

@joshua-goldstein
Copy link
Contributor

Running npm install on current package gives unresolved peer dependency:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: tslint-microsoft-contrib@6.2.0
npm ERR! Found: tslint@6.1.3
npm ERR! node_modules/tslint
npm ERR!   dev tslint@"^6.1.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.1.0" from tslint-microsoft-contrib@6.2.0
npm ERR! node_modules/tslint-microsoft-contrib
npm ERR!   dev tslint-microsoft-contrib@"^6.2.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: tslint@5.20.1
npm ERR! node_modules/tslint
npm ERR!   peer tslint@"^5.1.0" from tslint-microsoft-contrib@6.2.0
npm ERR!   node_modules/tslint-microsoft-contrib
npm ERR!     dev tslint-microsoft-contrib@"^6.2.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Hence why we currently require npm install --legacy-peer-deps. This is because https://github.com/microsoft/tslint-microsoft-contrib is out of date and no longer maintained. We should switch to a more modern linter. Perhaps https://github.com/typescript-eslint/typescript-eslint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant