Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Locally error's are not returned to user #47

Open
antondubek opened this issue Sep 11, 2023 · 3 comments
Open

Bug: Locally error's are not returned to user #47

antondubek opened this issue Sep 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@antondubek
Copy link

When hitting the /embed endpoint with incorrect parameters a 500 internal server error is thrown not the error from within the application.

Examples:

  • No pinecone credentials / incorrect pinecone credentials
  • Missing / incorrect EmbeddingsMetadata
  • Missing / incorrect VectorDBMetadata
<!doctype html>
<html lang=en>
<title>500 Internal Server Error</title>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.</p>
@dgarnitz
Copy link
Owner

Are you running stale code? have you tried pulling, rebuilding the images and re-running the containers?

There is logic to return different types of 400 errors for those scenarios

@dgarnitz
Copy link
Owner

@antondubek a larger problem beyond this is how return errors to the user that have occurred deeper in the system.

since its a distributed system, we would have to write the errors to a central store somewhere and expose access to them via API.

@dgarnitz
Copy link
Owner

dgarnitz commented Apr 4, 2024

@antondubek we will resolve this issue with this one here - #88

@dgarnitz dgarnitz added the bug Something isn't working label Apr 4, 2024
@dgarnitz dgarnitz mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antondubek @dgarnitz