Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tests for Rules #106

Open
highpost opened this issue Oct 9, 2019 · 0 comments
Open

new tests for Rules #106

highpost opened this issue Oct 9, 2019 · 0 comments

Comments

@highpost
Copy link

highpost commented Oct 9, 2019

I meant to respond to PRs #99 and #100 sooner, but it took a lot more work to get that done. In the end I wrote a lot of pytests to exercise the new features developed by @efficiosoft: model-based permissions and permissions derived automatically from view types. Those both look great. I really like model-based permissions.

I also wrote tests to exercise the integration between Rules and Django Rest Framework. This led to PR #105. With that in place I think you can say that Django Rules works with DRF as a permission backed envisioned by https://www.django-rest-framework.org/api-guide/permissions/#object-level-permissions. To support that I would like to submit documentation PRs for DRF to advertise that fact. I think a documentation PR for Django itself would also be helpful.

The tests are in https://github.com/highpost/rules_test and if you want to add them to Rules I would like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant