Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Distinguish IOCs between cases #462

Open
c8y3 opened this issue Apr 9, 2024 · 2 comments
Open

[FR] Distinguish IOCs between cases #462

c8y3 opened this issue Apr 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@c8y3
Copy link
Contributor

c8y3 commented Apr 9, 2024

Is your feature request related to a problem?
Currently IOCs are shared between different cases. They are are uniquely determined by their type and value (see https://github.com/dfir-iris/iris-web/blob/v2.4.7/source/app/datamgmt/case/case_iocs_db.py#L171).
This is problem in different scenarios.
For instance:

  • create a first case
  • add a IOC to the case with type identifier 1 and value "some value"
  • create a second case
  • add a IOC to the case with type identifier 1 and value "some value" and tags "tag1,tag2"
  • retrieve the IOC on the second case
  • => the value of its tags will be None (because it was not created/updated, because it is the same IOC as the one set on the first case)

Also, because of the permssion system (https://docs.dfir-iris.org/latest/operations/access_control/), a user is not necessarily allowed to have accesses to all cases. However, currently he can still indirectly impact the IOCs of cases he does not have access to. This can also lead to potential data-leaks.

Describe the solution you'd like
IOCs should be associated to a case. Even if an IOC on a case has the same type and value than the IOC on another case, it should be a different object. When one is modified, the other one is left untouched.

Implementation tips
Compare with assets?

@c8y3 c8y3 added the enhancement New feature or request label Apr 9, 2024
@c8y3 c8y3 changed the title [FR] Do not share IOCs between cases anymore [FR] Distinguish IOCs between cases Apr 9, 2024
@SecMeyo
Copy link

SecMeyo commented Apr 22, 2024

I absolutely second this FR. I think the Linked Cases column in the IOC table can be data breach material as well and therefore should not be part of any downloadable export

@Matthijsy
Copy link
Contributor

This actually is related to another issue as well: #304. I totally agree with this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants