Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nether portals and their mechanics #385

Open
JustTalDevelops opened this issue Jan 3, 2022 · 0 comments · May be fixed by #426
Open

Implement nether portals and their mechanics #385

JustTalDevelops opened this issue Jan 3, 2022 · 0 comments · May be fixed by #426
Assignees
Labels
feature New feature or request
Milestone

Comments

@JustTalDevelops
Copy link
Member

JustTalDevelops commented Jan 3, 2022

This is a slightly tricky issue, because traditionally the code used for portals, specifically nether portals, is quite... awful, and creating an API that fits the rest of Dragonfly's design philosophies is also going to be a bit of a design challenge. However, there are plenty of clever approaches that can be taken, and after a few of the bigger hurdles, it is generally quite simple. A couple notes I took a little while back:

  • The vanilla portal implementation scans first on the west/east directions, and then the south/north directions.
  • The maximum portal width and height, including the frame, is 23 blocks.
  • The minimum portal width is 4 blocks, and the minimum height is 5 blocks, both including the frame.

There are a few decent implementations worth looking into, such as MiNET's or the work-in-progress GlowstoneMC implementation.

I think most of all, we should try to aim for:

  • A fluid API to make it easy to utilize portals in code.
  • Vanilla functionality.
  • Minimal code. (this is where plenty of other implementations fail, for example, Nukkit's.)
@JustTalDevelops JustTalDevelops added the feature New feature or request label Jan 3, 2022
@Sandertv Sandertv added this to the v0.6.0 milestone Jan 3, 2022
@JustTalDevelops JustTalDevelops linked a pull request Feb 19, 2022 that will close this issue
@JustTalDevelops JustTalDevelops self-assigned this Feb 24, 2022
@Sandertv Sandertv modified the milestones: v0.6.0, v0.7.0 Apr 2, 2022
@JustTalDevelops JustTalDevelops modified the milestones: v0.7.0, v0.8.0 Jun 6, 2022
@Sandertv Sandertv reopened this Jul 15, 2022
@DaPigGuy DaPigGuy modified the milestones: v0.8.0, v0.9.0 Aug 1, 2022
@DaPigGuy DaPigGuy modified the milestones: v0.9.0, v0.10.0 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants