Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable parameters and their dependancies #13

Open
calebsheridan opened this issue Apr 25, 2024 · 4 comments
Open

Enable/disable parameters and their dependancies #13

calebsheridan opened this issue Apr 25, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@calebsheridan
Copy link
Contributor

calebsheridan commented Apr 25, 2024

Suggestion for UX:

  1. Allow parameters to be explicitly disabled (which results in using their default values, regardless of the input value).
  2. If there are dependant parameters (e.g.: Mirostat must be enabled for Mirostat-Tau and Mirostat-Eta), the dependant parameters respect the parent's status.
    3. Promote System Prompt from Settings Modal to Form Grid (it is the only parameter in Settings). By default, disable system prompt.

Disabled params will appear gray and only display on one line:

<title> <tooltip> <toggle>

Enabling params will appear normal and display on three lines:

<title> <tooltip> <toggle>
<input>
<explanation>
@dezoito
Copy link
Owner

dezoito commented Apr 25, 2024

Thank you for the suggestions.

I'll definitely consider #3 first, as it's the less messy to implement.
To disable the system prompt all you have to do is to leave it empty.

@dezoito dezoito closed this as completed Apr 25, 2024
@calebsheridan
Copy link
Contributor Author

If the suggestions are ok, we can leave the issue open until someone can work on it

@dezoito dezoito reopened this Apr 25, 2024
@dezoito
Copy link
Owner

dezoito commented Apr 25, 2024

Done.

@dezoito
Copy link
Owner

dezoito commented Apr 26, 2024

@calebsheridan

System prompt promoted to main form as of v0.4.0 (plus the changes you submitted and other minor updates)

Thank you for the input and PRs.

@dezoito dezoito added the enhancement New feature or request label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants