Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarized Light in Vim sets background to dark in Kitty #44

Open
FernandoBasso opened this issue Feb 25, 2021 · 2 comments
Open

Solarized Light in Vim sets background to dark in Kitty #44

FernandoBasso opened this issue Feb 25, 2021 · 2 comments

Comments

@FernandoBasso
Copy link

FernandoBasso commented Feb 25, 2021

The themes/Solarized_Light.conf theme is producing a dark background in Vim with 'altercation/vim-colors-solarized'.

From inside vim, :echo &background reports “light”, and :echo $TERM reports “xterm-kitty”.

That said, I tried using this Solarized Light from a kitty issue) and it works fine.

I could also add that this vim solarized light theme I use works fine with all VTE terminals I have tried (xfce4-terminal, mate-terminal, terminator, all using the solarized palette) and also using those terminals + tmux.

EDIT: I took sometime to debug the problem, and it looks like color7 and color15 are the ones causing Vim Solarized Light to have a dark background.

Proposed Fix

I suggest replacing the current (which causes the darkish stuff mentioned above):

color7 #262626
color15 #1c1c1c

With these (from the issue I linked above, which really makes a lightish backround theme for Vim Solarized Light and do not seem to cause any color strangeness or unintended consequence for the terminal itself not running an editor):

color7  #eee8d5
color15  #fdf6e3
@vikahl
Copy link

vikahl commented Aug 5, 2021

Just wanted to say thank you for the fix as I had the same problem but did not manage to solve it myself.

@krzkrzkrz
Copy link

Yeap, this fix works for me too

The themes/Solarized_Light.conf theme is producing a dark background in Vim with 'altercation/vim-colors-solarized'.

From inside vim, :echo &background reports “light”, and :echo $TERM reports “xterm-kitty”.

That said, I tried using this Solarized Light from a kitty issue) and it works fine.

I could also add that this vim solarized light theme I use works fine with all VTE terminals I have tried (xfce4-terminal, mate-terminal, terminator, all using the solarized palette) and also using those terminals + tmux.

EDIT: I took sometime to debug the problem, and it looks like color7 and color15 are the ones causing Vim Solarized Light to have a dark background.

Proposed Fix

I suggest replacing the current (which causes the darkish stuff mentioned above):

color7 #262626
color15 #1c1c1c

With these (from the issue I linked above, which really makes a lightish backround theme for Vim Solarized Light and do not seem to cause any color strangeness or unintended consequence for the terminal itself not running an editor):

color7  #eee8d5
color15  #fdf6e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants