Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudRendererMixin contains a big chunk of copypasted code #407

Open
SollyW opened this issue Jul 21, 2021 · 3 comments
Open

CloudRendererMixin contains a big chunk of copypasted code #407

SollyW opened this issue Jul 21, 2021 · 3 comments
Labels
Todo Needs done before next update, preferably
Projects
1.7

Comments

@SollyW
Copy link
Member

SollyW commented Jul 21, 2021

CloudRendererMixin::internalCloudRender copies a large chunk of code from WorldRenderer::renderClouds. For maintainability and copyright reasons this should be avoided
@CDAGaming
Copy link
Contributor

Agree with this, though to do so would need a major refactoring. I would be open to a PR having a more maintainable system however.

@CDAGaming CDAGaming added Priority This issue should be a priority. Todo Needs done before next update, preferably labels Jul 21, 2021
@Jack-Papel Jack-Papel removed the Todo Needs done before next update, preferably label Nov 8, 2021
@CDAGaming
Copy link
Contributor

Slated for PL b1.7

@CDAGaming CDAGaming added the Todo Needs done before next update, preferably label Feb 5, 2022
@Jack-Papel Jack-Papel added this to To do in 1.7 Feb 5, 2022
@Jack-Papel Jack-Papel removed the Priority This issue should be a priority. label Jul 4, 2022
@MBatt1 MBatt1 added the Priority This issue should be a priority. label Apr 17, 2024
@MBatt1 MBatt1 removed the Priority This issue should be a priority. label Apr 27, 2024
@MBatt1
Copy link
Contributor

MBatt1 commented Apr 27, 2024

Pushing this back- I'm not smart enough to refactor this but we make very small changes that would still require replacing the code with a mixin because of the data that we modify. Tried some workarounds but ended up infinitely looping because we mixin directly to the render clouds method and then would need to call it ourselves to not duplicate code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Todo Needs done before next update, preferably
Projects
No open projects
1.7
To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@CDAGaming @SollyW @MBatt1 @Jack-Papel