Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic vs static allocation #21

Open
devonmpowell opened this issue Mar 8, 2021 · 2 comments
Open

Dynamic vs static allocation #21

devonmpowell opened this issue Mar 8, 2021 · 2 comments

Comments

@devonmpowell
Copy link
Owner

@ibaned @shevitz @raovgarimella @MackKenamond
I am opening this for a new discussion thread.

I pulled Rao's work on the dynamically allocated buffer.
But given all the discussion around a smart build system, would it make sense to have CMake control not only the value of R3D_MAX_VERTS, but also whether the code uses static vs dynamic allocation? We could make the API consistent for both cases, so that one could switch at will (i.e., r3d_init_poly() would really do nothing in the static case, but could be left in for consistency)

@ibaned
Copy link
Contributor

ibaned commented Mar 8, 2021

If the language were C++, that could be controlled by template parameters as well. Not saying that's the best idea, depends on everyone's willingness to use C++.

@raovgarimella
Copy link
Contributor

That would take some work (for which I don't have time right now). Unless others see a need for actually having this be a thing, I am fine with letting it die. It was an instructive experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants