Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request.responseBody not defined #166

Open
mtscrb opened this issue Oct 18, 2019 · 0 comments
Open

Fix request.responseBody not defined #166

mtscrb opened this issue Oct 18, 2019 · 0 comments

Comments

@mtscrb
Copy link

mtscrb commented Oct 18, 2019

Related to #163

In nativeSend, the request.responseBody sometimes it's undefined, when the responseType is empty.

Refer to https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseType

We need to have a fallback to either responseText or response based on the responseType.
Something like

const response = new _Response.Response(request.status, request.responseBody || request.responseText || request.response, headers);

Also, in _handleResponse we are stringifying the response without checking the responseType
We should do something like:

      if (this.responseType === "blob") {
        if (body instanceof Blob) {
          this._response = body;
        } else {
          this._response = new Blob([body]);
        }
      } else if (this.responseType === "json") {
        this._response = JSON.stringify(body);
      } else {
        this._response = body;
      }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant