Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user_action in waves notebooks #81

Open
rbanerjee20 opened this issue Sep 10, 2020 · 0 comments · May be fixed by #72
Open

Implement user_action in waves notebooks #81

rbanerjee20 opened this issue Sep 10, 2020 · 0 comments · May be fixed by #72
Assignees
@jakubbober
Labels
devito Requires Devito knowledge python Requires Python knowledge testing wave Wave equations section

Comments

@rbanerjee20
Copy link
Collaborator

rbanerjee20 commented Sep 10, 2020 •
edited

Due to time constraints, I wasn't able to get this working during my project. It would be great if the waves notebooks I worked on could have the user_action function implemented so more of the test suite could be run.

It should be achievable by passing save=Nt into the TimeFunction (say, u), and then running user_action on the values in u.data once the Operator has been applied.
@rbanerjee20 rbanerjee20 added devito Requires Devito knowledge python Requires Python knowledge wave Wave equations section testing labels Sep 10, 2020
@jakubbober jakubbober linked a pull request Sep 21, 2020 that will close this issue
WIP: wave1D_fd2 #72
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubbober jakubbober

Labels
devito Requires Devito knowledge python Requires Python knowledge testing wave Wave equations section
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: wave1D_fd2 devitocodes/devito_book
2 participants
@rbanerjee20 @jakubbober