Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkerArgs specs are too narrow #136

Closed
rlipscombe opened this issue Nov 28, 2019 · 1 comment
Closed

WorkerArgs specs are too narrow #136

rlipscombe opened this issue Nov 28, 2019 · 1 comment

Comments

@rlipscombe
Copy link

In poolboy:child_spec/3, poolboy:start/2 and poolboy:start_link/2, WorkerArgs is specified as proplists:proplist(). For example:

-spec start_link(PoolArgs :: proplists:proplist(),
                 WorkerArgs:: proplists:proplist())
    -> start_ret().

However, this value is passed directly to the worker's start_link function, and it doesn't have to be a proplist.

This is causing dialyzer to issue warnings for my project.

rlipscombe added a commit to rlipscombe/poolboy that referenced this issue Nov 29, 2019
@rlipscombe
Copy link
Author

Duplicate of #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant