Hi @vinokurig. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Does this work locally in odov3? I'm unsure if the failure is related to our CI or the stack itself.

https://github.com/devfile/registry/actions/runs/8782390440/job/24096589141?pr=370#step:10:24997

cc @thepetk might be related to a combination of both because java stacks have given us issues in the past.

@Jdubrick Could be a result of what I've provided feedback on: #370 (comment)

FYI @vinokurig

/retest

Does this work locally in odov3? I'm unsure if the failure is related to our CI or the stack itself.

https://github.com/devfile/registry/actions/runs/8782390440/job/24096589141?pr=370#step:10:24997

cc @thepetk might be related to a combination of both because java stacks have given us issues in the past.

@Jdubrick locally it works for me by downloading the .zip file extract it and then run the devfile inside. Is strange that it doesn't work if I directly do:

$ odo init --devfile-path https://raw.githubusercontent.com/vinokurig/registry/java-quarkus-j-21/stacks/java-quarkus/1.5.0/devfile.yaml --name some

$ odo dev

Error:

[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.041 s
[INFO] Finished at: 2024-04-23T11:30:36Z
[INFO] ------------------------------------------------------------------------
[ERROR] The goal you specified requires a project to execute but there is no POM in this directory (/projects). Please verify you invoked Maven from the correct directory. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException

This PR will close devfile/api#1542

@michael-valdron @Jdubrick Looks like all comments have been addressed, could you please take a look?

/ok-to-test

Does this work locally in odov3? I'm unsure if the failure is related to our CI or the stack itself.
https://github.com/devfile/registry/actions/runs/8782390440/job/24096589141?pr=370#step:10:24997
cc @thepetk might be related to a combination of both because java stacks have given us issues in the past.

@Jdubrick locally it works for me by downloading the .zip file extract it and then run the devfile inside. Is strange that it doesn't work if I directly do:

$ odo init --devfile-path https://raw.githubusercontent.com/vinokurig/registry/java-quarkus-j-21/stacks/java-quarkus/1.5.0/devfile.yaml --name some

$ odo dev

Error:

[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.041 s
[INFO] Finished at: 2024-04-23T11:30:36Z
[INFO] ------------------------------------------------------------------------
[ERROR] The goal you specified requires a project to execute but there is no POM in this directory (/projects). Please verify you invoked Maven from the correct directory. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException

New changes work for me locally by doing it this way, I'm curious if it is possible to not use the zip way and instead mimic what all the other devfiles are doing to get the source files? This may be why Quarkus is giving us issues in tests as it is the only stack that uses zip to get the source.

I'm curious if it is possible to not use the zip way and instead mimic what all the other devfiles are doing to get the source files? This may be why Quarkus is giving us issues in tests as it is the only stack that uses zip to get the source.

@Jdubrick We need to use zip for Java Quarkus because the starter projects are generated as archived source projects on request from the Code with Quarkus community and the Code with Quarkus Red Hat product web services.

@michael-valdron

Running odo dev gives the following error:

[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:3.10.0:dev (default-cli) on project code-with->quarkus: Detected Maven Version (3.8.5)  is not supported, it must be in [3.8.6,). -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

This is related to devfile/api#1541 as applying this suggested fix solves the build error.

Could you please elaborate more on how to fix the build? I tried to use the ./mvnw but the script is not present as the project is not downloaded.

Also aligned with #399

@michael-valdron can you please review this and merge, as this would be needed for IDE extensions using devfiles.

If you've tested this working I'm fine merging but why is it the force move to 21 is required for ide ext release ? Is the fixes for java 17 not sufficient?

@maxandersen It seems the projects being generated by code.quarkus.io use Java 21 by default. When trying out vscode-openshift, Don Schenck ran into this; the project he was working with used Java 21, and the suggested Devfile used Java 17.

Yes but code.quarkus.redhat.com will use java 17.

Anyhow - seems no way for dev file to handle these differences well thus Ill +1 and if any reports of product issues we'll have to tell users to manually update the image.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, maxandersen, michael-valdron, svor, vinokurig

The full list of commands accepted by this bot can be found here.

The pull request process is described here