Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for async generator functions #38

Open
hjfreyer opened this issue Dec 29, 2019 · 0 comments · May be fixed by #39
Open

Add support for async generator functions #38

hjfreyer opened this issue Dec 29, 2019 · 0 comments · May be fixed by #39

Comments

@hjfreyer
Copy link

Promises are great, but async iterators would be even more general.
johnsonjo4531 added a commit to johnsonjo4531/workerize that referenced this issue Dec 30, 2019
@johnsonjo4531
generator and async generator support
2e95131 
fixes developit#38
First thing to note about this is that I broke the microbundle build.
I'll attempt to fix the generator function to not use things microbundle
doesn't expect, but I'm not sure how far I'll get
with that. Which that's also something tying up this pull request:
developit/greenlet#50

One other thing to note about this is that I decided on
returning a promise of the asyncIterator from the generator function.
This is due to the fact that the function from the user only ever gets
evaluated as an executable function on the worker side.
@johnsonjo4531 johnsonjo4531 linked a pull request Dec 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

generator and async generator support johnsonjo4531/workerize
1 participant
@hjfreyer