Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservations can be cancelled #15

Open
developeregrem opened this issue Nov 1, 2019 · 3 comments
Open

Reservations can be cancelled #15

developeregrem opened this issue Nov 1, 2019 · 3 comments
Labels
enhancement New feature or request Reservations all issues concerning the Reservations

Comments

@developeregrem
Copy link
Owner

It must be possible to cancel a reservation.
A new button should be added to the modal (click on Reservation).
When you click on the button, the reservation should "disappear" and be marked as cancelled in the DB. (The room can be reassigned).
A new attribute must be inserted in the Reservation entity to indicate whether a reservation has been cancelled or not.
Only reservations that have not been canceled can be displayed in the reservation overview.
At the same time, the check to see whether a room is available (create / edit new reservation) must also be adjusted so that only reservations that have not been canceled are queried.

Canceled reservations are to be evaluated later for the statistics module.

@developeregrem developeregrem added enhancement New feature or request Reservations all issues concerning the Reservations labels Nov 1, 2019
@daking88
Copy link
Contributor

daking88 commented Apr 2, 2024

what about doing this via the "status" of a reservation? adding a new status is easy, we then just need to think about a "fixed" canceled status. we could then as well easily filter for the records.

@developeregrem
Copy link
Owner Author

Yes would be an option. Some additional thoughts that came into my mind:

  • should canceled reservations still be visible/accessible from the UI or should we just take this for statistical analysis (just a flag in the database)
  • if only as "ghost" in the database the change to "canceled" can not be undone a new reservation must be created if this was a mistake
  • if still be visible in the UI -> HOW? Currently, only one reservation can be displayed for the same apartment and period. If we have one canceled and afterwards one new confirmed reservation, this is not possible atm. However, it could be possible to resolve this conflict with Allow more than one reservation for the same period #70 where I'm currently working on.

@daking88
Copy link
Contributor

daking88 commented May 9, 2024

To be honest, I wouldn't show it in the calendar and rather hide it. It would only confuse. It does not necessarily mean we can't get it back, or? How about a sub menu viewing all cancelled and there you can revert the change. Would then more or less be a state change, as said above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Reservations all issues concerning the Reservations
Projects
None yet
Development

No branches or pull requests

2 participants