Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is rate limitting done in your clients? #20

Open
toonsevrin opened this issue Apr 2, 2020 · 2 comments
Open

How is rate limitting done in your clients? #20

toonsevrin opened this issue Apr 2, 2020 · 2 comments

Comments

@toonsevrin
Copy link

toonsevrin commented Apr 2, 2020

Dear bol devs,

For my company, TCorp BV, I generated a go-client (source) from the openapi/swagger specification.

It appears that rate limiting is not part of the specification, and thus none of this information can be processed correctly by my generated client.

How did you deal with this over the various clients?

Also: bol.com's rate limiting is extremely low: Is it recommended that we write an indexing service (that indexes orders when they come in etc.) between bol.com and the rest of our internal services?

@toonsevrin
Copy link
Author

EDIT: This is related to the actual retailer api, my apoligies. If you know the answers however, feel free to inform me!

@Niellles
Copy link

I've just realised that, unfortunately, there's nothing that handles rate limiting in this library. The response you get from the API has X-RateLimit-Remaining and X-RateLimit-Reset headers. See: https://tools.ietf.org/id/draft-polli-ratelimit-headers-00.html#rfc.section.3. I am planning on using these headers to handle rate limiting in my application.

As for your second question:

3.11. bol.com stelt de Limiet vast en is gerechtigd om de Limiet van tijd tot tijd aan te passen. Overschrijding van de Limiet kan resulteren in een (tijdelijke) blokkade van de toegang tot de Open- Api voor de betreffende Open API gebruiker. Het lokaal opslaan van de Content is, met inachtneming van het bepaalde in artikel 3.7, toegestaan.
~ Bol Open API Terms of Service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants