Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in error type #186

Open
2e0byo opened this issue May 14, 2023 · 1 comment
Open

typo in error type #186

2e0byo opened this issue May 14, 2023 · 1 comment
Labels

Comments

@2e0byo
Copy link
Contributor

2e0byo commented May 14, 2023

oops, we have a type s/RunTimeError/RuntimeError/

  File "/home/john/code/16-channel/.venv/lib/python3.11/site-packages/skidl/tools/kicad/kicad.py", line 752, in _parse_lib_part_kicad_v6
    part_defn = parse_sexp(self.part_defn, allow_underflow=True)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/john/code/16-channel/.venv/lib/python3.11/site-packages/skidl/utilities.py", line 833, in parse_sexp
    raise RunTimeError("Bracketing mismatch!")
          ^^^^^^^^^^^^
NameError: name 'RunTimeError' is not defined. Did you mean: 'RuntimeError'?

(and I've messed up editing a file).

@2e0byo 2e0byo added the bug label May 14, 2023
@2e0byo
Copy link
Contributor Author

2e0byo commented May 14, 2023

hmm I think there's another bug here: the error clearly says 'bracketing mismatch' which I'd naively assume meant too many of one of ( or ). But in fact the error is caused by changing the name of a symbol so it doesn't match one of property "value" or the inner symbol (prob. the former). So at the very least this error should be clearer.

I need to prove a proper MWE for this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant