Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skidl part parameters not carried forward into netlists #176

Open
rtpavlovsk21 opened this issue Jan 12, 2023 · 0 comments
Open

Skidl part parameters not carried forward into netlists #176

rtpavlovsk21 opened this issue Jan 12, 2023 · 0 comments

Comments

@rtpavlovsk21
Copy link
Contributor

Currently when defining a part one can supply additional kwargs:

from skidl import Part

cust_part = Part(main_lib, '0402_resistor,  description='0402_10v',footprint='main_lib:0402',value=10, manf_num="panasonicseriesX",datasheet='res_0402_pansonicseriesX')

However on the generation of netlists these additional keyword arguments are not passed to the kicad netlist_gen_comp netlist generator, only the cust_part.fields are passed (additionally if kwargs of similar names are passed ie datasheet they are not updated). Is this intentional?

Potentially when parts are created with updated kwargs they could

for k, v in list(kwargs.items()):
            setattr(self, k, v)
            if k.capitalize() in self.fields.keys():
                self.fields[k.capitalize()] = v

which replaces part information in the generated netlist. The parts loaded in kicad may not get these changes, since the parts in the library would need to update. The netlist would then store information about the parts as entered in skidl... which appear to be otherwise redundant with information loaded from kicad.

Some keywords, such as 'value' are passed to kicad, so potentially Kicad can also read these info from the netlist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant