Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL6 accepts crypto settings from openssh 5.9 #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojciech-kopras
Copy link

To fix #125

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojciech-kopras this looks great. Thank you. @artem-sidorenko do you think this is good to go?

@chris-rock
Copy link
Member

@wojciech-kopras can you make the DCO bot happy?

Signed-off-by: Wojciech Kopras <wojciech.kopras@yahoo.com>
@artem-sidorenko
Copy link
Member

artem-sidorenko commented May 14, 2019

Looks good to me, I'll cross-check it with chef-ssh-hardening, I also want to verify if this support was backported by RH (because of version detection logic in chef-ssh-hardening). Maybe we have here some edge case, which wasn't covered in the past, not sure yet

@chris-rock
Copy link
Member

@artem-sidorenko Once you're okay, we can merge this this PR.

@artem-sidorenko
Copy link
Member

artem-sidorenko commented Aug 23, 2019 via email

@artem-sidorenko
Copy link
Member

artem-sidorenko commented Sep 6, 2019

I'm not really sure how to handle this..
how it looks like this support this backported ny RH or we really missed something in the past.
If it was backported -> we would have to introduce some logic to the openssh version discovery library within chef-ssh-hardening to cover this edge case.

Sorry if it takes more time again, but I'll have to find another time to technically cross-check this with ansible-ssh-hardening and chef-ssh-hardening in order to know what would break and how it can be handled.

@chris-rock
Copy link
Member

@artem-sidorenko Can we just activate this on the latest 6.x version of Redhat/Centos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh 5.3 on CentOS 6 supports macs59
3 participants