Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't follow all proxies #85

Open
krzkaczor opened this issue Feb 25, 2022 · 1 comment
Open

Doesn't follow all proxies #85

krzkaczor opened this issue Feb 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@krzkaczor
Copy link
Member

https://etherscan.io/address/0x25ace71c97B33Cc4729CF772ae268934F7ab5fA1#code

@krzkaczor krzkaczor added the bug Something isn't working label Feb 25, 2022
@hasparus
Copy link
Contributor

hasparus commented Mar 2, 2022

There are two approaches to this.

  1. Currently, Etherscan knows it's a proxy and we don't. We could use &action=getsourcecode instead of action=getabi when calling Etherscan to receive the implementation address in Implementation field alongside the ABI in ABI field. We already have code for this in Ethereum Code Viewer / Dethcode.

  2. A solution agnostic about ABI source: In this particular case, we'd need to replicate

 address target = addressManager[address(this)].getAddress(
  (implementationName[address(this)])
);

And I'm not sure if this one is feasible. There is only a constructor and a fallback in the ABI, both implementationName mapping and addressManager mapping are private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants