Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Embed Solidity Comments/Documentation with Typescript Types #61

Open
wottpal opened this issue Nov 29, 2021 · 4 comments

Comments

@wottpal
Copy link

wottpal commented Nov 29, 2021

Disclaimer: I'm very new in this field of development. Sorry, if I have taken something completely wrong in advance :D

Wouldn't it be nice if the types generated by typechain/eth-sdk would also include the comments/documentation provided within the solidity contract files? So that if I hover over a function in VSCode the documentation pops up? I guess that task is not so easy as the comments are not included within the ABIs downloaded from etherscan, right?

@krzkaczor
Copy link
Member

Hey @wottpal,

this is a great question actually and having this feature would have a perfect sense!

These kinds of comments are called natspect and TypeChain (which we use under the hood) has already limited support for them. The problem is that natspec is stripped out by etherscan so we don't have a good source for abi with natspec.

I think that Sourcify provides them but the amount of verified contracts there is limited for now.

@wottpal
Copy link
Author

wottpal commented Dec 4, 2021

Hey, thanks for your reply. So to conclude, it would be helpful if the etherscan APIs would also provide natspect side-by-side with the ABIs, right? Should we ask in their Reddit for it? (I just noticed their project isn't OS which feels a little bit odd as they are such an integral part of web3-tooling).

@krzkaczor
Copy link
Member

@wottpal yeah, sounds good. You should ask them about it.

@wottpal
Copy link
Author

wottpal commented Jan 13, 2022

just for the records: https://www.reddit.com/r/etherscan/comments/s2zr9o/provide_contract_natspect_together_with_abis/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants